Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check

[Eric Blake]

On 08/22/2014 09:44 AM, Max Reitz wrote:
> This is not a consequence of the extracted functions moving up, but
> because of check_refblocks() preceding calculate_refcounts(). Splitting
> the check won't help; and I know that Eric dislikes
> (forward-)declarations of static functions (which I have to do if I pull
> calculate_refcounts() before check_refblocks()).

I may not like them in the end result, but they are perfectly fine for
an intermediate patch that is refactoring things, when coupled with a
followup patch that moves the refactored code into topological order.

Anything we can do to make reviewing easier, even if it requires going
through more commits and more lines of churn to get there, pays off in
the long run.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature