[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/9] qcow2: Fix leaks in dirty images
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/9] qcow2: Fix leaks in dirty images |
Date: |
Fri, 22 Aug 2014 10:09:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 08/15/2014 09:16 AM, Max Reitz wrote:
> When opening dirty images, qcow2's repair function should not only
> repair errors but leaks as well.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 435e0e1..8faa75d 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -790,7 +790,7 @@ static int qcow2_open(BlockDriverState *bs, QDict
> *options, int flags,
> (s->incompatible_features & QCOW2_INCOMPAT_DIRTY)) {
> BdrvCheckResult result = {0};
>
> - ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS);
> + ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS | BDRV_FIX_LEAKS);
> if (ret < 0) {
> error_setg_errno(errp, -ret, "Could not repair dirty image");
> goto fail;
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/9] qcow2: Fix image repairing, Max Reitz, 2014/08/15
- [Qemu-devel] [PATCH v2 1/9] qcow2: Fix leaks in dirty images, Max Reitz, 2014/08/15
- Re: [Qemu-devel] [PATCH v2 1/9] qcow2: Fix leaks in dirty images,
Eric Blake <=
- [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check, Max Reitz, 2014/08/15
- Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check, Benoît Canet, 2014/08/21
- Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check, Benoît Canet, 2014/08/21
- Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check, Eric Blake, 2014/08/21
- Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check, Benoît Canet, 2014/08/21
- Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check, Max Reitz, 2014/08/22
- Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check, Benoît Canet, 2014/08/22
- Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check, Max Reitz, 2014/08/22
- Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check, Max Reitz, 2014/08/22
- Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check, Eric Blake, 2014/08/22