Re: [Qemu-devel] [PATCH v3 10/10] iotests: Add test for potentially damaging repairs

[Benoît Canet]

On Fri, Aug 22, 2014 at 01:55:01PM -0600, Eric Blake wrote:
> On 08/22/2014 10:31 AM, Max Reitz wrote:
> > There are certain cases where repairing a qcow2 image might actually
> > damage it further (or rather, where repairing it has in fact damaged it
> > further with the old qcow2 check implementation). This should not
> > happen, so add a test for these cases.
> > 
> > Signed-off-by: Max Reitz <address@hidden>
> > ---
> >  tests/qemu-iotests/104     | 98 
> > ++++++++++++++++++++++++++++++++++++++++++++++
> >  tests/qemu-iotests/104.out | 46 ++++++++++++++++++++++
> >  tests/qemu-iotests/group   |  1 +
> >  3 files changed, 145 insertions(+)
> >  create mode 100755 tests/qemu-iotests/104
> >  create mode 100644 tests/qemu-iotests/104.out
> > 
> > diff --git a/tests/qemu-iotests/104 b/tests/qemu-iotests/104
> > new file mode 100755
> > index 0000000..cc6d0b3
> > --- /dev/null
> > +++ b/tests/qemu-iotests/104
> > @@ -0,0 +1,98 @@
> > +#!/bin/bash
> > +#
> > +# Test case for repairing qcow2 images which cannot be repaired using
> > +# the on-disk refcount structures
> > +#
> > +# Copyright (C) 2013 Red Hat, Inc.
> 
> Welcome to 2014, where we are practically 2/3 through with the year
> already :)

It may have been copied from an existing template so maybe the initial copyright
is really from 2013.

Benoît

> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>