Re: [Qemu-devel] [PATCH v6 0/4] test virtio-blk hotplug

[Amos Kong]

On Sun, Jul 06, 2014 at 08:14:46PM +0800, Amos Kong wrote:
> On Wed, Jun 25, 2014 at 09:15:12AM +0800, Amos Kong wrote:
> > It's worth to add a hotplug test to qtest, but without
> > cooperation of guest OS, new devices can't be initialized
> > by guest, and hot-unplug doesn't work.
> > 
> > However, the new test can cover some part of code of
> > hotplug/unplug.
> > 
> > I will write another subtest to test hotplug with pci support.
> > 
> > V2: move qmp_exec_hmp_cmd() to libqtest.c
> >     excape hmp cmd (stefanha)
> >     use qmp_exec_hmp_cmd() in blockdev-test
> > V3: use vp_list to format string, free escaped string
> > V4: free escaped string by g_free()
> > V5: escape cmd string in QMP command (so this patchset depends on 
> >     http://article.gmane.org/gmane.comp.emulators.qemu/279835)
> >     directly use QMP cmd to add/del device and blockdev
> >     cleanup as suggested by Andreas
> > V6: hot-unplug devices of one slot once
> >     escaping string fix in 1st patch depends on 
> >     (https://lists.nongnu.org/archive/html/qemu-devel/2014-06/msg03024.html)
> 
> Kevin, Stefan, Andreas
> 
> Can you help to review & apply this set?


ping :-)
 
> Thanks. Amos
>  
> > Amos Kong (4):
> >   qtest: introduce qmp_exec_hmp_cmd()
> >   qtest: use qmp_exec_hmp_cmd() in blockdev-test
> >   virtio-blk-test: change pci_nop() to virtblk_init()
> >   virtio-blk-test: add hotplug subtest
> > 
> >  tests/blockdev-test.c   | 23 ++------------
> >  tests/libqtest.c        | 23 ++++++++++++++
> >  tests/libqtest.h        |  9 ++++++
> >  tests/virtio-blk-test.c | 81 
> > ++++++++++++++++++++++++++++++++++++++++++++-----
> >  4 files changed, 108 insertions(+), 28 deletions(-)
> > 
> > -- 
> > 1.9.3

-- 
                        Amos.