[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE |
Date: |
Mon, 25 Aug 2014 00:18:11 +0200 |
When memory is allocated on a wrong node, MPOL_MF_STRICT
doesn't move it - it just fails the allocation.
A simple way to reproduce the failure is with mlock=on
realtime feature.
The code comment actually says: "ensure policy won't be ignored"
so setting MPOL_MF_MOVE seems like a better way to do this.
Cc: address@hidden
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
backends/hostmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backends/hostmem.c b/backends/hostmem.c
index e7eec37..99e8f99 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -295,7 +295,7 @@ host_memory_backend_memory_complete(UserCreatable *uc,
Error **errp)
/* ensure policy won't be ignored in case memory is preallocated
* before mbind(). note: MPOL_MF_STRICT is ignored on hugepages so
* this doesn't catch hugepage case. */
- unsigned flags = MPOL_MF_STRICT;
+ unsigned flags = MPOL_MF_STRICT | MPOL_MF_MOVE;
/* check for invalid host-nodes and policies and give more verbose
* error messages than mbind(). */
--
MST
- [Qemu-devel] [PULL 00/11] pci, pc fixes, features, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 02/11] pci_bridge: manually destroy memory regions within PCIBridgeWindows, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 03/11] pcihp: fix possible array out of bounds, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 05/11] Add ACPI tables for TPM, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 04/11] pc: reserve more memory for ACPI for new machine types, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 07/11] pcie: Fix incorrect write to the ari capability next function field, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 06/11] ssdt-tpm: add generated hex file to git, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 08/11] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_*, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 10/11] ioh3420: Enable ARI forwarding, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 11/11] pcie: fix trailing whitespace, Michael S. Tsirkin, 2014/08/24