[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Fwd: [PATCH v4 07/21] iscsi: Handle failure for potent
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [Fwd: [PATCH v4 07/21] iscsi: Handle failure for potentially large allocations] |
|
Date: |
Mon, 25 Aug 2014 10:56:56 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
Il 24/08/2014 21:31, Peter Lieven ha scritto:
> Am 24.08.2014 um 18:30 schrieb Paolo Bonzini:
>> Il 22/08/2014 10:42, Kevin Wolf ha scritto:
>>>> Unfortunately, I missed that one. The zeroblock is typicalls 512 Byte or
>>>> 4K depending
>>>> on the blocksize.
>>> I don't remember the details, but I think when I went through all
>>> drivers, I couldn't convince myself that a reasonable block size is
>>> enforced somewhere. So I just went ahead and converted the call to be on
>>> the safe side. It can never hurt anyway.
>> Yeah, a malicious iSCSI target could have unreasonable block sizes.
> Maybe we should just allow 512b or 4kb blocksize and refuse
> all other?
At least CDs and DVDs use 2kb blocksize. :)
Paolo