[Qemu-devel] bad error message in drive-mirror

[Eric Blake]

I just noticed today that passing "granularity":1 to QMP drive-mirror
results in this confusing error message:

Invalid parameter 'drive-virtio-disk0'

because the code mistakenly did
        error_set(errp, QERR_INVALID_PARAMETER, device);
instead of the correct
        error_set(errp, QERR_INVALID_PARAMETER, "granularity");

I ran out of time to patch it today, and at any rate, whoever writes the
patch should probably audit for other bad uses of
error_set(QERR_INVALID_PARAMETER).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature