[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests. |
Date: |
Tue, 26 Aug 2014 20:57:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 08/26/2014 08:38 PM, Fam Zheng wrote:
> On Tue, 08/26 21:48, Richard W.M. Jones wrote:
>> Some servers (notably VMware ESX) accept range requests, but don't
>> send back the Accept-Ranges: bytes header in their initial response.
>>
>> For these servers you can set override_accept_ranges to 'on' which
>> forces this block driver to send range requests anyway.
Is this a case where we should be naming with dashes instead of
underscores, as in override-accept-ranges?
>> @@ -489,6 +490,11 @@ static QemuOptsList runtime_opts = {
>> .type = QEMU_OPT_BOOL,
>> .help = "Verify SSL certificate"
>> },
>> + {
>> + .name = CURL_BLOCK_OPT_OVERRIDE_ACCEPT_RANGES,
>> + .type = QEMU_OPT_BOOL,
>> + .help = "Server accepts range requests"
>> + },
It would be nice for someone to finally port the QAPI counterpart
(BlockdevOptions) so that curl devices can be hotplugged via
blockdev-add. But I guess that's a separate patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature