[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from
|
From: |
Andrey Korolyov |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1. |
|
Date: |
Wed, 27 Aug 2014 12:51:59 +0400 |
On Wed, Aug 27, 2014 at 12:39 PM, tangchen <address@hidden> wrote:
>
> On 08/26/2014 10:24 PM, Andrey Korolyov wrote:
>>
>> ......
>>
>> Just to remind - Windows will not add pc dimms without populated SRAT,
>> so imho forcing NUMA topology to be set (and whose support is required
>> anyway from guest linux kernel in order to support ACPI hotplug) is
>> better than approach proposed by this patch.
>> .
>
> Hi Andrey,
>
> Sorry, I don't quite understand. If Windows won't add pc-dimm without SRAT,
> why is this approach not enough ? If there is no SRAT, there is no NUMA
> topology.
> Why do we need to set a NUMA topology ?
>
> Thanks.
Sorry, probably it was a bit unclear. I thnk that there should be no
cases when dimm is plugged (and check from patch is fired up) without
actually populated NUMA, because not every OS will workaround this by
faking the node.