[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force
From: |
Richard W.M. Jones |
Subject: |
Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests. |
Date: |
Wed, 27 Aug 2014 11:16:15 +0100 |
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Wed, Aug 27, 2014 at 08:37:22AM +0200, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
> > On 08/26/2014 08:38 PM, Fam Zheng wrote:
> >> On Tue, 08/26 21:48, Richard W.M. Jones wrote:
> >>> Some servers (notably VMware ESX) accept range requests, but don't
> >>> send back the Accept-Ranges: bytes header in their initial response.
> >>>
> >>> For these servers you can set override_accept_ranges to 'on' which
> >>> forces this block driver to send range requests anyway.
> >
> > Is this a case where we should be naming with dashes instead of
> > underscores, as in override-accept-ranges?
>
> Yes.
Thanks for reviewing. I'm actually going to drop this for a couple of
reasons:
- VMware vSphere does send the header, only ESX doesn't.
- When you access ESX (using this patch) eventually the ESX web
server crashes. In a sense ESX was correct that it doesn't support
ranges -- because it's buggy.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org