[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate
From: |
Pavel Dovgaluk |
Subject: |
Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate |
Date: |
Wed, 27 Aug 2014 14:48:22 +0400 |
> From: Paolo Bonzini [mailto:address@hidden
> Il 27/08/2014 12:30, Pavel Dovgaluk ha scritto:
> >> From: Paolo Bonzini [mailto:address@hidden
> >> Il 27/08/2014 12:15, Pavel Dovgaluk ha scritto:
> >>>>> Again, this is only needed in your record/replay system (and you haven't
> >>>>> yet quite explained why the design has this limitation), so it should
> >>>>> not be a part of this series.
> >>> I see. Updating s->timer and s->TimerExpire in post_load will be enough?
> >>
> >> In theory it should be done already, I guess it's not deterministic
> >> enough though.
> >
> > I split existing function into the two parts: one sets irq (and calls
> > another).
> > And the second part sets only timer and TimerExpire fields. The second
> > function
> > is also called from post_load.
> >
> >> Have you tried my patch to rewrite the timer stuff?
> >
> > What patch do you mean?
>
> This one:
>
> http://article.gmane.org/gmane.comp.emulators.qemu/288521
It will solve the problem, because it removes raising an irq from
rtl8139_set_next_tctr_time function.
Ok then, I'll remove my rtl8139 patch from the series.
Pavel Dovgalyuk
- Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate, (continued)
- [Qemu-devel] [PATCH 07/12] hpet: fixing saving and loading process, Pavel Dovgalyuk, 2014/08/26
- [Qemu-devel] [PATCH 08/12] pckbd: adding new fields to vmstate, Pavel Dovgalyuk, 2014/08/26
- [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate, Pavel Dovgalyuk, 2014/08/26
- Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate, Paolo Bonzini, 2014/08/26
- Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate, Pavel Dovgaluk, 2014/08/27
- Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate, Paolo Bonzini, 2014/08/27
- Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate, Pavel Dovgaluk, 2014/08/27
- Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate, Paolo Bonzini, 2014/08/27
- Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate,
Pavel Dovgaluk <=
- Message not available
- Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate, Paolo Bonzini, 2014/08/27
- Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate, Pavel Dovgaluk, 2014/08/28
- Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate, Paolo Bonzini, 2014/08/28
[Qemu-devel] [PATCH 10/12] piix: do not raise irq while loading vmstate, Pavel Dovgalyuk, 2014/08/26
[Qemu-devel] [PATCH 11/12] mc146818rtc: add missed field to vmstate, Pavel Dovgalyuk, 2014/08/26
[Qemu-devel] [PATCH 12/12] pl031: add missed field to vmstate, Pavel Dovgalyuk, 2014/08/26