[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate |
|
Date: |
Wed, 27 Aug 2014 14:35:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 27/08/2014 14:16, Pavel Dovgaluk ha scritto:
>> > Can you use a vm_change_state_handler, or a QEMU_CLOCK_VIRTUAL timer
>> > with expiration time in the past (e.g. at time zero) to run the sync
>> > code as soon as possible? Then you can preserve the current migration
>> > format and avoid using the invalid APIC state.
> Does this method guarantee, that nobody (like other timers) will access
> APIC between loading the vmstate and invocation of the timer?
Hmm, probably not. The bug would not be other timers accessing the
APIC, because that would also call apic_sync_vapic and the only effect
would be an extra useless synchronization. The bug would happen if the
APIC is accessed by the CPU before the timer has the occasion to run.
However, a vm_change_state_handler should work. It runs before VCPUs
are started.
Paolo
- Re: [Qemu-devel] [PATCH 02/12] pcspk: adding vmstate for save/restore, (continued)
[Qemu-devel] [PATCH 07/12] hpet: fixing saving and loading process, Pavel Dovgalyuk, 2014/08/26
[Qemu-devel] [PATCH 08/12] pckbd: adding new fields to vmstate, Pavel Dovgalyuk, 2014/08/26
[Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate, Pavel Dovgalyuk, 2014/08/26