[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/6] trace: avoid Python 2.5 all() in traceto
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/6] trace: avoid Python 2.5 all() in tracetool |
Date: |
Wed, 27 Aug 2014 16:16:35 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
The Wednesday 27 Aug 2014 à 12:08:53 (+0100), Stefan Hajnoczi wrote :
> Red Hat Enterprise Linux 5 ships Python 2.4.3. The all() function was
> added in Python 2.5 so we cannot use it.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> scripts/tracetool/backend/__init__.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/tracetool/backend/__init__.py
> b/scripts/tracetool/backend/__init__.py
> index 5bfa1ef..d4b6dab 100644
> --- a/scripts/tracetool/backend/__init__.py
> +++ b/scripts/tracetool/backend/__init__.py
> @@ -102,7 +102,8 @@ class Wrapper:
> def __init__(self, backends, format):
> self._backends = [backend.replace("-", "_") for backend in backends]
> self._format = format.replace("-", "_")
> - assert all(exists(backend) for backend in self._backends)
> + for backend in self._backends:
> + assert exists(backend)
> assert tracetool.format.exists(self._format)
>
> def _run_function(self, name, *args, **kwargs):
> --
> 1.9.3
>
>
Reviewed-by: Benoît Canet <address@hidden>
- [Qemu-devel] [PATCH v2 0/6] Fixes for buildbot failures, Stefan Hajnoczi, 2014/08/27
- [Qemu-devel] [PATCH v2 1/6] qapi.py: avoid Python 2.5+ any() function, Stefan Hajnoczi, 2014/08/27
- [Qemu-devel] [PATCH v2 2/6] libqtest: launch QEMU with QEMU_AUDIO_DRV=none, Stefan Hajnoczi, 2014/08/27
- [Qemu-devel] [PATCH v2 3/6] trace: avoid Python 2.5 all() in tracetool, Stefan Hajnoczi, 2014/08/27
- Re: [Qemu-devel] [PATCH v2 3/6] trace: avoid Python 2.5 all() in tracetool,
Benoît Canet <=
- [Qemu-devel] [PATCH v2 4/6] mirror: fix uninitialized variable delay_ns warnings, Stefan Hajnoczi, 2014/08/27
- [Qemu-devel] [PATCH v2 5/6] block: sort formats alphabetically in bdrv_iterate_format(), Stefan Hajnoczi, 2014/08/27
- [Qemu-devel] [PATCH v2 6/6] Revert "qemu-img: sort block formats in help message", Stefan Hajnoczi, 2014/08/27