[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] qcow2: Fix leak of opts in qcow2_open
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] qcow2: Fix leak of opts in qcow2_open |
Date: |
Thu, 28 Aug 2014 12:06:12 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, 08/27 19:40, Max Reitz wrote:
> On 27.08.2014 08:02, Fam Zheng wrote:
> >Not all the error paths release opts, fix it by moving it after the fail
> >label.
> >
> >Signed-off-by: Fam Zheng <address@hidden>
> >---
> > block/qcow2.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
>
> This is pretty much the same patch as 'qcow2: Fix leak of QemuOpts in
> qcow2_open()' from my 'qapi/block-core: Add "new" qcow2 options' series. I
> guess it's up to the maintainer(s) which one gets pulled, I just want to
> point out that pulling one means leaving out the other.
Since I need to respin this series, I will drop this one and leave it for your
series.
Thanks for pointing out. :)
Fam
- Re: [Qemu-devel] [PATCH 1/4] nfs: Fix leak of opts in nfs_file_open, (continued)