qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qmp: using genneric string paring function for


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] qmp: using genneric string paring function for 'qom-set'
Date: Thu, 28 Aug 2014 05:14:31 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0

On 08/27/2014 11:19 PM, address@hidden wrote:
> From: Gonglei <address@hidden>
> 

In the subject: s/genneric/generic/, s/paring/parsing/

> At present, 'qom-set' only can set string type property,

qom-set is typed as taking arbitrary JSON 9one of the few commands with
'gen':'no', which means it is completely type-unsafe, and can therefore
accept EVERY type, including JSON integers, not just strings).

> which will restrict this qmp command's function.
> Using genneric string paring function can handle different

Same typos here as in subject.

> types, such as int/bool/string etc.
> 
> Signed-off-by: Gonglei <address@hidden>
> ---

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]