[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 8/8] memory: Lazy init name from QOM name as needed
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 8/8] memory: Lazy init name from QOM name as needed |
Date: |
Thu, 28 Aug 2014 16:13:25 +0200 |
From: Peter Crosthwaite <address@hidden>
To support name retrieval of MemoryRegions that were created
dynamically (that is, not via memory_region_init and friends). We
cache the name in MemoryRegion's state as
object_get_canonical_path_component mallocs the returned value
so it's not suitable for direct return to callers. Memory already
frees the name field, so this will be garbage collected along with
the MR object.
Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
memory.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/memory.c b/memory.c
index 42317a2..ef0be1c 100644
--- a/memory.c
+++ b/memory.c
@@ -1309,6 +1309,10 @@ uint64_t memory_region_size(MemoryRegion *mr)
const char *memory_region_name(const MemoryRegion *mr)
{
+ if (!mr->name) {
+ ((MemoryRegion *)mr)->name =
+ object_get_canonical_path_component(OBJECT(mr));
+ }
return mr->name;
}
--
1.8.3.1
- [Qemu-devel] [PULL 0/8] SCSI and memory changes for 2014-08-28, Paolo Bonzini, 2014/08/28
- [Qemu-devel] [PULL 3/8] block/iscsi: fix memory corruption on iscsi resize, Paolo Bonzini, 2014/08/28
- [Qemu-devel] [PULL 1/8] block: Pass errp in blkconf_geometry, Paolo Bonzini, 2014/08/28
- [Qemu-devel] [PULL 4/8] scsi-generic: remove superfluous DPRINTF avoid to break compiling, Paolo Bonzini, 2014/08/28
- [Qemu-devel] [PULL 6/8] xen-hvm: Constify string, Paolo Bonzini, 2014/08/28
- [Qemu-devel] [PULL 2/8] scsi-bus: Convert DeviceClass init to realize, Paolo Bonzini, 2014/08/28
- [Qemu-devel] [PULL 7/8] xen: hvm: Abstract away memory region name ref, Paolo Bonzini, 2014/08/28
- [Qemu-devel] [PULL 5/8] virtio-scsi: Report error if num_queues is 0 or too large, Paolo Bonzini, 2014/08/28
- [Qemu-devel] [PULL 8/8] memory: Lazy init name from QOM name as needed,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL 0/8] SCSI and memory changes for 2014-08-28, Peter Maydell, 2014/08/28