qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver
Date: Fri, 29 Aug 2014 08:48:11 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Fam Zheng <address@hidden> writes:

> On Thu, 08/28 16:23, Eric Blake wrote:
>> On 08/27/2014 11:53 PM, Fam Zheng wrote:
>> > This is an analogue to Linux null_blk. It can be used for testing block
>> > device emulation and general block layer functionalities such as
>> > coroutines and throttling, where disk IO is not necessary or wanted.
>> > 
>> > Use null:// for AIO version, and null-co:// for coroutine version.
>> > 
>> > Signed-off-by: Fam Zheng <address@hidden>
>> > 
>> > ---
>> 
>> > +++ b/qapi/block-core.json
>> > @@ -1150,7 +1150,8 @@
>> >    'data': [ 'archipelago', 'file', 'host_device', 'host_cdrom', 
>> > 'host_floppy',
>> >              'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat', 'blkdebug',
>> >              'blkverify', 'bochs', 'cloop', 'cow', 'dmg', 'parallels', 
>> > 'qcow',
>> > -            'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', 'quorum' 
>> > ] }
>> > +            'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', 'quorum',
>> > +            'null' ] }
>> 
>> As mentioned elsewhere, you probably want 'null' AND 'null-co'.  Bummer
>> that this list is mostly alphabetical, but that 'quorum' and 'null' are
>> out of order.
>
> I'll add null-co to the list. But this list is a bit far from alphabetical:
>
> archipelago, ..., vvfat, blkdebug,...

Two sensible ways to organize lists of things: keep it sorted
alphabetically by name, or order by some ontology.  Since ontology is
neither obvious nor relevant here, I'd go for alphabetic.

Separate cleanup patch, please.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]