[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] kvm: do not abort if KVM_RUN fails
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH] kvm: do not abort if KVM_RUN fails |
Date: |
Fri, 29 Aug 2014 16:11:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
On 29/08/14 15:58, Paolo Bonzini wrote:
> Just go to the internal error runstate. This lets you use the "x",
> "dump-guest-memory" or "info register" commands.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Christian Borntraeger <address@hidden>
Very nice. This helps a lot in understanding some problems. (Even if those are
rare).
Christian
> ---
> kvm-all.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index b240bf8..f5edcb1 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1738,7 +1738,8 @@ int kvm_cpu_exec(CPUState *cpu)
> }
> fprintf(stderr, "error: kvm run failed %s\n",
> strerror(-run_ret));
> - abort();
> + ret = -1;
> + break;
> }
>
> trace_kvm_run_exit(cpu->cpu_index, run->exit_reason);
>