[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 02/11] qcow2: Fix leaks in dirty images
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v5 02/11] qcow2: Fix leaks in dirty images |
Date: |
Fri, 29 Aug 2014 23:40:54 +0200 |
When opening dirty images, qcow2's repair function should not only
repair errors but leaks as well.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: BenoƮt Canet <address@hidden>
---
block/qcow2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 172ad00..82bca88 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -900,7 +900,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options,
int flags,
(s->incompatible_features & QCOW2_INCOMPAT_DIRTY)) {
BdrvCheckResult result = {0};
- ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS);
+ ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS | BDRV_FIX_LEAKS);
if (ret < 0) {
error_setg_errno(errp, -ret, "Could not repair dirty image");
goto fail;
--
2.1.0
- [Qemu-devel] [PATCH v5 00/11] qcow2: Fix image repairing, Max Reitz, 2014/08/29
- [Qemu-devel] [PATCH v5 01/11] qcow2: Calculate refcount block entry count, Max Reitz, 2014/08/29
- [Qemu-devel] [PATCH v5 02/11] qcow2: Fix leaks in dirty images,
Max Reitz <=
- [Qemu-devel] [PATCH v5 03/11] qcow2: Split qcow2_check_refcounts(), Max Reitz, 2014/08/29
- [Qemu-devel] [PATCH v5 04/11] qcow2: Pull check_refblocks() up, Max Reitz, 2014/08/29
- [Qemu-devel] [PATCH v5 05/11] qcow2: Reuse refcount table in calculate_refcounts(), Max Reitz, 2014/08/29
- [Qemu-devel] [PATCH v5 06/11] qcow2: Fix refcount blocks beyond image end, Max Reitz, 2014/08/29
- [Qemu-devel] [PATCH v5 07/11] qcow2: Do not perform potentially damaging repairs, Max Reitz, 2014/08/29
- [Qemu-devel] [PATCH v5 08/11] qcow2: Rebuild refcount structure during check, Max Reitz, 2014/08/29
- [Qemu-devel] [PATCH v5 09/11] qcow2: Clean up after refcount rebuild, Max Reitz, 2014/08/29
- [Qemu-devel] [PATCH v5 11/11] iotests: Add test for potentially damaging repairs, Max Reitz, 2014/08/29
- [Qemu-devel] [PATCH v5 10/11] iotests: Fix test outputs, Max Reitz, 2014/08/29