Re: [Qemu-devel] [PATCH v2] rules.mak: Fix DSO build by pulling in archive symbols

[Peter Maydell]

On 1 September 2014 13:04, Paolo Bonzini <address@hidden> wrote:
> Il 01/09/2014 13:46, Peter Maydell ha scritto:
>> So we could fix this by not compiling empty files...
>
> Easy for int128, even easier for getauxval (it's not a fastpath, so we
> can move the "always return 0" version from include/qemu/osdep.h to
> util/getauxval.c).
>
> I'm not sure how to detect that there generated-tracers.c is empty.
> Stefan, is it used by anything except $(CONFIG_TRACE_SIMPLE)?

You could always put in a dummy function that isn't actually
used by anything.

>> ranlib doesn't like that either (this one's a warning we've had for
>> a long time):
>
> Given this, do you consider th a blocker for this patch?

The ranlib warnings are comparatively clear and only happen
when we link the .a file; the warnings we get out of nm are
rather uglier and more confusing and produced at every final
binary link. I'd certainly prefer it if we could fix them, but I
guess I won't absolutely insist on it.

-- PMM