[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 3/3] target-sparc: is_translating_asi() is TARGET
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH v2 3/3] target-sparc: is_translating_asi() is TARGET_SPARC64 only |
Date: |
Tue, 2 Sep 2014 12:52:44 +0100 |
Move the is_translating_asi() inside the TARGET_SPARC64 ifdef (and remove
the unimplemented 32-bit codepath), as it is only called from TARGET_SPARC64
code. This fixes a clang 3.4 unused-function warning.
Again, this allows us to remove an 'inline' tag that was there
largely to suppress gcc warnings.
Signed-off-by: Peter Maydell <address@hidden>
---
target-sparc/ldst_helper.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/target-sparc/ldst_helper.c b/target-sparc/ldst_helper.c
index 2d028a5..9f65bc3 100644
--- a/target-sparc/ldst_helper.c
+++ b/target-sparc/ldst_helper.c
@@ -262,11 +262,12 @@ static target_ulong address_mask(CPUSPARCState *env1,
target_ulong addr)
}
#endif
+#ifdef TARGET_SPARC64
/* returns true if access using this ASI is to have address translated by MMU
otherwise access is to raw physical address */
-static inline int is_translating_asi(int asi)
+/* TODO: check sparc32 bits */
+static int is_translating_asi(int asi)
{
-#ifdef TARGET_SPARC64
/* Ultrasparc IIi translating asi
- note this list is defined by cpu implementation
*/
@@ -283,13 +284,8 @@ static inline int is_translating_asi(int asi)
default:
return 0;
}
-#else
- /* TODO: check sparc32 bits */
- return 0;
-#endif
}
-#ifdef TARGET_SPARC64
static target_ulong asi_address_mask(CPUSPARCState *env,
int asi, target_ulong addr)
{
--
1.9.1