[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/13] vhost_net: cleanup start/stop condition
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 09/13] vhost_net: cleanup start/stop condition |
Date: |
Tue, 2 Sep 2014 18:07:33 +0300 |
Checking vhost device internal state in vhost_net looks like
a layering violation since vhost_net does not
set this flag: it is set and tested by vhost.c.
There seems to be no reason to check this:
caller in virtio net uses its own flag,
vhost_started, to ensure vhost is started/stopped
as appropriate.
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
---
hw/net/vhost_net.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index f87c798..9bbf2ee 100644
--- a/hw/net/vhost_net.c
+++ b/hw/net/vhost_net.c
@@ -195,10 +195,6 @@ static int vhost_net_start_one(struct vhost_net *net,
struct vhost_vring_file file = { };
int r;
- if (net->dev.started) {
- return 0;
- }
-
net->dev.nvqs = 2;
net->dev.vqs = net->vqs;
net->dev.vq_index = vq_index;
@@ -256,10 +252,6 @@ static void vhost_net_stop_one(struct vhost_net *net,
{
struct vhost_vring_file file = { .fd = -1 };
- if (!net->dev.started) {
- return;
- }
-
if (net->nc->info->type == NET_CLIENT_OPTIONS_KIND_TAP) {
for (file.index = 0; file.index < net->dev.nvqs; ++file.index) {
const VhostOps *vhost_ops = net->dev.vhost_ops;
--
MST
- [Qemu-devel] [PULL 00/13] pci, pc fixes, features, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 02/13] intel-iommu: introduce Intel IOMMU (VT-d) emulation, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 03/13] intel-iommu: add DMAR table to ACPI tables, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 04/13] intel-iommu: add Intel IOMMU emulation to q35 and add a machine option "iommu" as a switch, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 06/13] intel-iommu: add supports for queued invalidation interface, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 05/13] intel-iommu: fix coding style issues around in q35.c and machine.c, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 01/13] iommu: add is_write as a parameter to the translate function of MemoryRegionIOMMUOps, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 07/13] intel-iommu: add context-cache to cache context-entry, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 09/13] vhost_net: cleanup start/stop condition,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 08/13] intel-iommu: add IOTLB using hash table, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 10/13] ioh3420: remove unused ioh3420_init() declaration, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 11/13] virtio-net: don't run bh on vm stopped, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 12/13] pci: avoid losing config updates to MSI/MSIX cap regs, Michael S. Tsirkin, 2014/09/02
- [Qemu-devel] [PULL 13/13] vhost_net: start/stop guest notifiers properly, Michael S. Tsirkin, 2014/09/02
- Re: [Qemu-devel] [PULL 00/13] pci, pc fixes, features, Michael S. Tsirkin, 2014/09/03