Re: [Qemu-devel] [PULL 13/13] vhost_net: start/stop guest notifiers properly

[William Dauchy]

On Sep02 18:07, Michael S. Tsirkin wrote:
> From: Jason Wang <address@hidden>
> 
> commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue
> support changed the order of stopping the device. Previously
> vhost_dev_stop would disable backend and only afterwards, unset guest
> notifiers. We now unset guest notifiers while vhost is still
> active. This can lose interrupts causing guest networking to fail. In
> particular, this has been observed during migration.
> 
> To adapt this, several other changes are needed:
> - remove the hdev->started assertion in vhost.c since we may want to
> start the guest notifiers before vhost starts and stop the guest
> notifiers after vhost is stopped.
> - introduce the vhost_net_set_vq_index() and call it before setting
> guest notifiers. This is used to guarantee vhost_net has the correct
> virtqueue index when setting guest notifiers.
> 
> Cc: address@hidden
> Reported-by: "Zhangjie (HZ)" <address@hidden>
> Tested-by: William Dauchy <address@hidden>

please use:

Tested-by: William Dauchy <address@hidden>

> Signed-off-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Jason Wang <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>

Thanks,
-- 
William

signature.asc
Description: Digital signature