qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/2] qemu-img: fix rebase src_cache option do


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v2 2/2] qemu-img: fix rebase src_cache option documentation
Date: Tue, 02 Sep 2014 21:10:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0

On 02.09.2014 12:01, Stefan Hajnoczi wrote:
The src_cache option (-T) specifies the cache mode for backing files.
It applies both the image's old backing file as well as the new backing
file:

   ret = bdrv_open(&bs_old_backing, backing_name, NULL, NULL, src_flags,
                   old_backing_drv, &local_err);
   if (ret) {
       ...
   }
   if (out_baseimg[0]) {
       bs_new_backing = bdrv_new("new_backing", &error_abort);
       ret = bdrv_open(&bs_new_backing, out_baseimg, NULL, NULL, src_flags,
                       new_backing_drv, &local_err);
       if (ret) {
           ...
       }
   }

The documentation only mentions the new backing file but it really
applies to both.

Suggested-by: Jeff Nelson <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
  qemu-img.texi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Max Reitz <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]