[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-net: don't run bh on vm stopped
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] virtio-net: don't run bh on vm stopped |
|
Date: |
Wed, 3 Sep 2014 11:45:57 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Sep 02, 2014 at 05:26:12PM +0300, Michael S. Tsirkin wrote:
> commit 783e7706937fe15523b609b545587a028a2bdd03
> virtio-net: stop/start bh when appropriate
>
> is incomplete: BH might execute within the same main loop iteration but
> after vmstop, so in theory, we might trigger an assertion.
> I was unable to reproduce this in practice,
> but it seems clear enough that the potential is there, so worth fixing.
>
> Cc: address@hidden
> Reported-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/net/virtio-net.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
pgplEW0fxlXQ4.pgp
Description: PGP signature