Re: [Qemu-devel] [PATCH v4 00/14] ivshmem: update documentation, add client/server tools

[David Marchand]

Hello Eric,

On 09/02/2014 10:31 PM, Eric Blake wrote:
> On 09/02/2014 09:25 AM, David Marchand wrote:
> > Here is a patchset containing an update on ivshmem specs documentation and
> > importing ivshmem server and client tools.
> > These tools have been written from scratch and are not related to what is
> > available in nahanni repository.
> > I put them in contrib/ directory as the qemu-doc.texi was already telling the
> > server was supposed to be there.
> >
> > Changes since v3:
> > - first patch is untouched
> > - just restored the Reviewed-By Claudio in second patch
> > - following patches 3-8 take into account Stefan's comments
> > - patches 9-12 take into account Gonglei's comments
> > - patch 13 adjusts ivshmem-server default values
> > - last patch introduces a change in the ivshmem client-server protocol to
> >    check a protocol version at connect time
>
> Rather than introducing new files with bugs, followed by patches to
> clean it up, why not just introduce the new files correct in the first
> place?  I think you are better off squashing in a lot of the cleanup
> patches into patch 1.

Actually, I mentioned this in a previous email but did not get any comment.
So, I preferred to send the splitted patches to ease review (from my 
point of view).

Once code looks fine enough, I intend to keep only three patches :
- one for the initial import of ivshmem-client / server
- one for the documentation update
- one last with the protocol change

Is it okay this way ?


--
David Marchand