[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 15/16] vhost-scsi: init backend features earlier
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v2 15/16] vhost-scsi: init backend features earlier |
Date: |
Wed, 3 Sep 2014 16:45:45 +0300 |
As vhost core can use backend_features during init, clear it earlier to
avoid using uninitialized memory.
This use would be harmless since vhost scsi ignores the result
anyway, but initializing earlier will help prevent valgrind errors,
and make scsi and net behave similarly.
Cc: address@hidden
Acked-by: Paolo Bonzini <address@hidden>
Acked-by: Jason Wang <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/scsi/vhost-scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
index ddfe76a..7146e0e 100644
--- a/hw/scsi/vhost-scsi.c
+++ b/hw/scsi/vhost-scsi.c
@@ -238,6 +238,7 @@ static void vhost_scsi_realize(DeviceState *dev, Error
**errp)
s->dev.nvqs = VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues;
s->dev.vqs = g_new(struct vhost_virtqueue, s->dev.nvqs);
s->dev.vq_index = 0;
+ s->dev.backend_features = 0;
ret = vhost_dev_init(&s->dev, (void *)(uintptr_t)vhostfd,
VHOST_BACKEND_TYPE_KERNEL, true);
@@ -246,7 +247,6 @@ static void vhost_scsi_realize(DeviceState *dev, Error
**errp)
strerror(-ret));
return;
}
- s->dev.backend_features = 0;
error_setg(&s->migration_blocker,
"vhost-scsi does not support migration");
--
MST
- [Qemu-devel] [PULL v2 01/16] iommu: add is_write as a parameter to the translate function of MemoryRegionIOMMUOps, (continued)
- [Qemu-devel] [PULL v2 01/16] iommu: add is_write as a parameter to the translate function of MemoryRegionIOMMUOps, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 06/16] intel-iommu: add supports for queued invalidation interface, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 04/16] intel-iommu: add Intel IOMMU emulation to q35 and add a machine option "iommu" as a switch, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 07/16] intel-iommu: add context-cache to cache context-entry, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 05/16] intel-iommu: fix coding style issues around in q35.c and machine.c, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 09/16] vhost_net: cleanup start/stop condition, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 08/16] intel-iommu: add IOTLB using hash table, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 12/16] pci: avoid losing config updates to MSI/MSIX cap regs, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 10/16] ioh3420: remove unused ioh3420_init() declaration, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 14/16] vhost_net: init acked_features to backend_features, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 15/16] vhost-scsi: init backend features earlier,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v2 16/16] acpi-build: Set FORCE_APIC_CLUSTER_MODEL bit for FADT flags, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 11/16] virtio-net: don't run bh on vm stopped, Michael S. Tsirkin, 2014/09/03
- [Qemu-devel] [PULL v2 13/16] vhost_net: start/stop guest notifiers properly, Michael S. Tsirkin, 2014/09/03