[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] target-sparc: address_mask(), asi_addres
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] target-sparc: address_mask(), asi_address_mask() are TARGET_SPARC64 only |
|
Date: |
Wed, 03 Sep 2014 08:09:40 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 09/03/2014 01:49 AM, Artyom Tarasenko wrote:
> On Tue, Sep 2, 2014 at 1:52 PM, Peter Maydell <address@hidden> wrote:
>> The address_mask() and asi_address_mask() functions are only used in
>> TARGET_SPARC64 configs, so guard with ifdefs to avoid warnings about
>> unused functions in 32-bit builds.
>>
>> Since the main reason these functions were marked 'inline' was to
>> suppress unused-function warnings with gcc, we remove the 'inline'
>> as no longer necessary.
>
> I thought address_mask was inline because it's in the hot path.
> Wouldn't the removal hit performance?
The compiler will probably inline it itself as it sees fit.
r~