Re: [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option

[Kevin Wolf]

Am 04.09.2014 um 14:45 hat Richard W.M. Jones geschrieben:
> On Thu, Sep 04, 2014 at 02:35:22PM +0200, Kevin Wolf wrote:
> > Please change the code to always write zeros for FULL,
> 
> How is this useful for anyone?  You don't know if the underlying SAN
> is going to detect these zeroes or combine these blocks together.
> It's just slow for no reason.

It's slow for the reason that the user has requested it. Do you doubt
that users can know what their backend is doing? Why are you insisting
on providing only the functionality that you personally need?

I doubt it's a way to make many users happier, but if you insist, we can
leave full preallocation unsupported on raw-posix and allow only
metadata preallocation (which should still be fallocate() without a
zero-write fallback, so that you can rely on it being fast). But call it
by its name and don't say "full" when you only implement "metadata".

Kevin