[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 5/7] net: invoke callback when purging queue
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 5/7] net: invoke callback when purging queue |
Date: |
Thu, 4 Sep 2014 16:50:09 +0100 |
From: "Michael S. Tsirkin" <address@hidden>
devices rely on packet callbacks eventually running,
but we violate this rule whenever we purge the queue.
To fix, invoke callbacks on all packets on purge.
Set length to 0, this way callers can detect that
this happened and re-queue if necessary.
Cc: address@hidden
Cc: Jason Wang <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Acked-by: Jason Wang <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
net/queue.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/queue.c b/net/queue.c
index 859d02a..f948318 100644
--- a/net/queue.c
+++ b/net/queue.c
@@ -233,6 +233,9 @@ void qemu_net_queue_purge(NetQueue *queue, NetClientState
*from)
if (packet->sender == from) {
QTAILQ_REMOVE(&queue->packets, packet, entry);
queue->nq_count--;
+ if (packet->sent_cb) {
+ packet->sent_cb(packet->sender, 0);
+ }
g_free(packet);
}
}
--
1.9.3
- [Qemu-devel] [PULL 0/7] Net patches, Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 2/7] net: don't use set/get_pointer() in set/get_netdev(), Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 1/7] net: Forbid dealing with packets when VM is not running, Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 4/7] virtio: don't call device on !vm_running, Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 5/7] net: invoke callback when purging queue,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 3/7] virtio-net: don't run bh on vm stopped, Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 6/7] net: complete all queued packets on VM stop, Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 7/7] virtio-net: purge outstanding packets when starting vhost, Stefan Hajnoczi, 2014/09/04