Re: [Qemu-devel] [PATCH v4 0/2] add resize callback to ide/core

[Stefan Hajnoczi]

On Thu, Sep 04, 2014 at 11:42:15PM -0400, John Snow wrote:
> This patch series fixes incorrect IDENTIFY data returned
> for an IDE drive after a block_resize event by adding
> a resize callback for IDE devices.
> 
> Inconsistencies between identify routines are also
> removed so that they read easier.
> 
> V4:
>  - Added patch that makes the buffer and cache fill order for
>    identify routines more consistent.
>  - Fixed a bug where the very first call to IDENTIFY does not
>    return any size information.
> 
> V3:
>  - Factored out the size update into new functions.
>  - Fixed the size update for CFATA.
>  - Added assertion to clarify that ide_resize_cb is non-atapi.
> 
> V2:
>  - Do not attempt to update geometry values, to avoid clobbering
>    user-specified values, if they exist.
>  - Do not regenerate the entire IDENTIFY buffer to avoid losing
>    any settings that occurred during normal operation.
> 
> John Snow (2):
>   IDE: Fill the IDENTIFY request consistently
>   ide: Add resize callback to ide/core
> 
>  hw/ide/core.c | 97 
> +++++++++++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 74 insertions(+), 23 deletions(-)
> 
> -- 
> 1.9.3
> 
> 

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

pgp8QDHNuG7X1.pgp
Description: PGP signature