Re: [Qemu-devel] [PATCH 1/2] timers: Move NANOSECONDS_PER_SECONDS to timer.h for future reuse

[Benoît Canet]

On Fri, Sep 05, 2014 at 03:31:16PM +0100, Peter Maydell wrote:
> On 5 September 2014 15:21, Benoît Canet <address@hidden> wrote:
> > Signed-off-by: Benoît Canet <address@hidden>
> > ---
> >  include/qemu/throttle.h | 2 --
> >  include/qemu/timer.h    | 2 ++
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h
> > index b890613..1c639d2 100644
> > --- a/include/qemu/throttle.h
> > +++ b/include/qemu/throttle.h
> > @@ -27,8 +27,6 @@
> >  #include "qemu-common.h"
> >  #include "qemu/timer.h"
> >
> > -#define NANOSECONDS_PER_SECOND  1000000000.0
> > -
> >  typedef enum {
> >      THROTTLE_BPS_TOTAL,
> >      THROTTLE_BPS_READ,
> > diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> > index 5f5210d..70ce891 100644
> > --- a/include/qemu/timer.h
> > +++ b/include/qemu/timer.h
> > @@ -5,6 +5,8 @@
> >  #include "qemu-common.h"
> >  #include "qemu/notify.h"
> >
> > +#define NANOSECONDS_PER_SECOND  1000000000.0
> 
> I was slightly surprised to see this was a floating
> point constant rather than an integer. I wonder if
> we'll get bitten by that in future...

The origin is the throttle code which does a lot of computation on double.
I'll check if throttle works fine with this constants as an integer.

Best regards

Benoît

> 
> -- PMM