qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v6 0/3] ivshmem: update documentation, add client/se


From: David Marchand
Subject: [Qemu-devel] [PATCH v6 0/3] ivshmem: update documentation, add client/server tools
Date: Mon, 8 Sep 2014 11:17:47 +0200

Here is a patchset containing an update on ivshmem specs documentation and
importing ivshmem server and client tools.
These tools have been written from scratch and are not related to what is
available in nahanni repository.
I put them in contrib/ directory as the qemu-doc.texi was already telling the
server was supposed to be there.

Changes since v5:
- 1st patch
* fixed remaining coding style issues
* fixed checks on snprintf return code
* prefixed all symbols to avoid pollution
* fixed spelling mistakes in comments
* fixed function descriptions in headers
* added a signal handler on SIGTERM and only unlink server socket when server 
exits
* fixed fd leaks I identified in client when reconnecting to a server
- 3rd patch
* remove wrong debug message
* do not delay pci bar2 register

Changes since v4:
- squashed patches 3-13 from v4 into first patch
- reused reported error when parsing arguments in server
- fixed spelling mistakes in documentation in second patch

Changes since v3:
- first patch is untouched
- just restored the Reviewed-By Claudio in second patch
- following patches 3-8 take into account Stefan's comments
- patches 9-12 take into account Gonglei's comments
- patch 13 adjusts ivshmem-server default values
- last patch introduces a change in the ivshmem client-server protocol to
  check a protocol version at connect time

Changes since v2:
- fixed license issues in ivshmem client/server (I took hw/virtio/virtio-rng.c
  file as a reference).

Changes since v1:
- moved client/server import patch before doc update,
- tried to re-organise the ivshmem_device_spec.txt file based on Claudio
  comments (still not sure if the result is that great, comments welcome),
- incorporated comments from Claudio, Eric and Cam,
- added more details on the server <-> client messages exchange (but sorry, no
  ASCII art here).

By the way, there are still some functionnalities that need description (use of
ioeventfd, the lack of irqfd support) and some parts of the ivshmem code clearly
need cleanup. I will try to address this in future patches when these first
patches are ok.


-- 
David Marchand

David Marchand (3):
  contrib: add ivshmem client and server
  docs: update ivshmem device spec
  ivshmem: add check on protocol version in QEMU

 Makefile                                |    8 +
 configure                               |    3 +
 contrib/ivshmem-client/ivshmem-client.c |  440 +++++++++++++++++++++++++++++++
 contrib/ivshmem-client/ivshmem-client.h |  213 +++++++++++++++
 contrib/ivshmem-client/main.c           |  239 +++++++++++++++++
 contrib/ivshmem-server/ivshmem-server.c |  426 ++++++++++++++++++++++++++++++
 contrib/ivshmem-server/ivshmem-server.h |  165 ++++++++++++
 contrib/ivshmem-server/main.c           |  264 +++++++++++++++++++
 docs/specs/ivshmem_device_spec.txt      |  127 ++++++---
 hw/misc/ivshmem.c                       |   27 +-
 include/hw/misc/ivshmem.h               |   17 ++
 qemu-doc.texi                           |   10 +-
 12 files changed, 1903 insertions(+), 36 deletions(-)
 create mode 100644 contrib/ivshmem-client/ivshmem-client.c
 create mode 100644 contrib/ivshmem-client/ivshmem-client.h
 create mode 100644 contrib/ivshmem-client/main.c
 create mode 100644 contrib/ivshmem-server/ivshmem-server.c
 create mode 100644 contrib/ivshmem-server/ivshmem-server.h
 create mode 100644 contrib/ivshmem-server/main.c
 create mode 100644 include/hw/misc/ivshmem.h

-- 
1.7.10.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]