|
From: | Peter Lieven |
Subject: | Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests |
Date: | Mon, 08 Sep 2014 16:35:41 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
On 08.09.2014 15:58, Paolo Bonzini wrote:
Il 08/09/2014 15:56, Peter Lieven ha scritto:Look like you are changing the coroutine version. Some hardware like virtio-blk uses the AIO version of read and writes. What would happen if all the block drivers down the chain are AIO enabled ?The AIO version still goes through bdrv_co_do_readv/writev. However, error_report is not something you can use for guest-accessible error messages, unless you want your logs to fill up with error messages. :)So you would not throw an error msg here?No, though a trace could be useful.
Is there a howto somewhere how to implement that? Then I would send a v2 if there are no other complaints. Whats your opinion changed the max_xfer_len to 0xffff regardsless of use_16_for_rw in iSCSI? Peter
[Prev in Thread] | Current Thread | [Next in Thread] |