[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_net
|
From: |
Jason Wang |
|
Subject: |
Re: [Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_netdev() |
|
Date: |
Tue, 09 Sep 2014 11:03:02 +0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
On 09/05/2014 12:40 AM, Peter Maydell wrote:
> On 4 September 2014 17:21, Stefan Hajnoczi <address@hidden> wrote:
>> Unfortunately this patch breaks aarch64-softmmu qtests:
>> GTESTER check-qtest-aarch64
>> Broken pipe
>> GTester: last random seed: R02S6d8ab263ca56f8ae7a4b47bdf93fbc73
>>
>> Please take a look at what is causing this.
> Specifically, it breaks on all the ARM boards which have
> more than one built in ethernet device. Something in your
> patch is probably assuming there is only one (there's
> a somewhat suspicious "[0]" array reference, for instance).
>
> thanks
> -- PMM
>
The '[0]' dereference was introduced after multiqueue is supported.
Since there may be multiple pairs of peers for each nic.
The failure reason looks like the ncs[0] pointer should be validated
before trying to access them.
Will post V2.
Thanks