Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property

[Gonglei (Arei)]

Hi,

> Subject: RE: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property
> 
> > Subject: Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom
> property
> >
> > On Fri, Sep 05, 2014 at 04:37:32PM +0800, address@hidden wrote:
> > > From: Gonglei <address@hidden>
> > >
> > > Add a qom property with the same name 'bootindex',
> > > when we remove it form qdev property, things will
> > > continue to work just fine, and we can use qom features
> > > which are not supported by qdev property.
> > >
> > > Signed-off-by: Gonglei <address@hidden>
> > > ---
> > >  hw/ide/qdev.c | 14 ++++++++++++++
> > >  1 file changed, 14 insertions(+)
> > >
> > > diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
> > > index efab95b..9e2ed40 100644
> > > --- a/hw/ide/qdev.c
> > > +++ b/hw/ide/qdev.c
> > > @@ -191,6 +191,17 @@ static int ide_dev_initfn(IDEDevice *dev,
> > IDEDriveKind kind)
> > >      return 0;
> > >  }
> > >
> > > +static void ide_dev_instance_init(Object *obj)
> > > +{
> > > +    DeviceState *dev = DEVICE(obj);
> > > +    IDEDevice *d = DO_UPCAST(IDEDevice, qdev, dev);
> > > +
> > > +    device_add_bootindex_property(obj, &d->conf.bootindex,
> > > +                                  "bootindex",
> > > +                                  d->unit ? "/address@hidden" :
> "/address@hidden",
> > > +                                  &d->qdev, NULL);
> > > +}
> > > +
Oops, I found a thorny issue that the d->unit parameter had not been initialized
in ide_dev_instance_init(). d->unit maybe is a random value, which will against
the original purpose in this situation. 

What's your opinion, Eduardo? Thanks!

Best regards,
-Gonglei