Re: [Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore

[Juan Quintela]

Paolo Bonzini <address@hidden> wrote:
> From: Pavel Dovgalyuk <address@hidden>
>
> VMState added by this patch preserves correct
> loading of the PC speaker device state.
>
> This breaks migration to 2.1 and earlier.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

This should only be added for new machine types, right?

Later, Juan.

> @@ -192,6 +203,7 @@ static void pcspk_class_initfn(ObjectClass *klass, void 
> *data)
>  
>      dc->realize = pcspk_realizefn;
>      set_bit(DEVICE_CATEGORY_SOUND, dc->categories);
> +    dc->vmsd = &vmstate_spk;
>      dc->props = pcspk_properties;
>      /* Reason: pointer property "pit", realize sets global pcspk_state */
>      dc->cannot_instantiate_with_device_add_yet = true;