qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/10] piix: do not raise irq while loading vmst


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 09/10] piix: do not raise irq while loading vmstate
Date: Tue, 09 Sep 2014 19:16:19 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0

Il 09/09/2014 15:54, Michael S. Tsirkin ha scritto:
> 
> Hmm I don't understand.
> You are removing call to piix3_update_irq_levels
> this call is supposed to just sync up bus to
> irq level.
> 
> How can this change system state? Saved state
> is supposed to already be in sync.

i440FX/PIIX3 state is loaded before i8259, so the interrupt will never
be in the i8259 ISR.  I am not sure why it is a problem for
record/replay, but I think it's plausible to consider this a bug.  i8259
state should not be affected by the load of PIIX3 state, since i8259 is
migrated separately.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]