[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] hw/arm/boot: enable DTB support when bootin
From: |
Ard Biesheuvel |
Subject: |
Re: [Qemu-devel] [PATCH 6/6] hw/arm/boot: enable DTB support when booting ELF images |
Date: |
Tue, 9 Sep 2014 20:20:52 +0200 |
On 9 September 2014 20:17, Peter Maydell <address@hidden> wrote:
> On 9 September 2014 19:15, Ard Biesheuvel <address@hidden> wrote:
>> On 9 September 2014 20:08, Peter Maydell <address@hidden> wrote:
>>> (Thinking about it, that implies we either need a
>>> rom_del_blob() or we need to tell load_dtb() about
>>> areas of address space it needs to check for overlap
>>> with before it registers the rom blob for the dtb.)
>>>
>>
>> ... or we just call load_elf() again
>
> That won't work, because we'll still trip the overlap
> check in rom_load_all(), won't we?
>
Yeah, you're right. My fingers are moving faster than my brain again
I will go ahead and rework load_dtb() to take a max_size parameter,
and load the dtb only if its size doesn't exceed max_size.
This should be sufficient to (a) implement the ELF case, and (b) not
complicate the other call sites too much
- Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios, (continued)
[Qemu-devel] [PATCH 5/6] hw/arm/boot: load DTB as a ROM image, Ard Biesheuvel, 2014/09/05