qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tcg/README: fix movcond cond argument position


From: Max Filippov
Subject: Re: [Qemu-devel] [PATCH] tcg/README: fix movcond cond argument position
Date: Tue, 9 Sep 2014 16:18:19 -0700

On Tue, Sep 9, 2014 at 4:12 PM, Richard Henderson <address@hidden> wrote:
> On 09/09/2014 04:02 PM, Max Filippov wrote:
>> movcond has its cond argument first, not last. Fix that in
>> documentation.

> No.  The README is supposed to be documenting the *opcode* argument ordering,
> which really does place cond last.
>
> I agree the situation with the helpers using a different ordering is 
> confusing.
>  If we were going to change anything to match, it'd have to be the helpers --
> the concept of constant opcode arguments coming last is buried quite deep in 
> TCG.

Maybe put a note about that difference there? Seems like I hit it
every time I add
something to translate.c.

-- 
Thanks.
-- Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]