Re: [Qemu-devel] [PATCH 07/10] serial: fixing vmstate for save/restore

[Pavel Dovgaluk]

> From: Paolo Bonzini [mailto:address@hidden
> Il 09/09/2014 15:59, Juan Quintela ha scritto:
> > But poll_msl is "more" interesting, because we are not "reseting it".
> >
> > So, we have that if we are migrating from an old version, we would have
> > poll_msl == -1, and we used to have it to poll_msl == 0.
> >
> > Should we change it?
> >
> > I think that putting:
> >
> > s->poll_msl = 0;
> >
> > in preload, and
> >
> > static bool serial_poll_needed(void *opaque)
> > {
> >     SerialState *s = opaque;
> >     return s->poll_msl != 0;
> > }
> >
> > would give exactly the same behaviour for new qemus, and behave better
> > for older ones?
> 
> poll_msl is usually -1, so the "needed" function must be like Pavel wrote.
> 
> poll_msl is only used for serial port passthrough, which I guess we can
> say "just doesn't work" for migration on < 2.1.  In fact, putting
> migration + passthrough together is probably not a great idea. :)  We
> probably could drop ust the poll_msl/modem_status_poll subsection, but I
> assume Pavel had some kind of test case.

I have an example for record/replay.
Record can work with passthrough enabled. And it usually saves some vmstates.
In replay mode we emulate passthrough by sending data read from the log
as they were received from the real device. That's why we need correct 
state recovery even for these fields.

Pavel Dovgalyuk