[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc : Make hreg_store_msr ret
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc : Make hreg_store_msr returns exception |
|
Date: |
Wed, 10 Sep 2014 15:19:10 +0200 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 05.09.14 15:45, Pierre Mallard wrote:
> hreg_store_msr was both returning 0 or an exception number which could be
> POWERPC_EXCP_NONE. In case POWERPC_EXCP_NONE was returned, helper_store_msr
> was handling uncorrectly this return value and raise an exception. This patch
> correct this behavior by making hreg_store_msr always return an exception
> number, and helper_store_msr test for POWERPC_EXCP_NONE.
>
> Signed-off-by: Pierre Mallard <address@hidden>
Are you sure that's a bug, not a feature? I think this idea behind
POWERPC_EXCP_NONE in this code path is to pull the guest out of its TB
so that no stale code could be executed after an MSR.IR/DR change.
Alex