Re: [Qemu-devel] [PATCH 0/5] cpu/acpi: convert cpu hot plug to hotplug_handler API

[Igor Mammedov]

On Wed,  3 Sep 2014 17:06:12 +0800
Gu Zheng <address@hidden> wrote:

> 
> Gu Zheng (5):
>   acpi/cpu: add cpu hotplug callback function to match hotplug_handler
>     API
>   acpi:ich9: convert cpu hotplug handle to hotplug_handler API
>   acpi:piix4: convert cpu hotplug handle to hotplug_handler API
>   pc: add cpu hotplug handler to PC_MACHINE
>   cpu/hotplug: remove the left unused cpu hotplug notifier function
> 
>  hw/acpi/cpu_hotplug.c         |   18 ++++++++++++------
>  hw/acpi/ich9.c                |   15 +++------------
>  hw/acpi/piix4.c               |   16 +++-------------
>  hw/i386/pc.c                  |   26 +++++++++++++++++++++++++-
>  include/hw/acpi/cpu_hotplug.h |    6 ++++--
>  include/hw/acpi/ich9.h        |    1 -
>  qom/cpu.c                     |    1 -
>  7 files changed, 47 insertions(+), 36 deletions(-)
> 

Looks like right direction that would allow to drop cpu_added_notifiers
which is not able to pass/handle errors and switch to unified hotplug handler
API which allows to pass errors and would allow to cancel device_add in case of
error.

PS:
Gu Zheng,

Please grep for qemu_register_cpu_added_notifier(), you've missed to convert
rtc usage of CPU notifier.

I'd prefer this to go in before you device_add/add cpu series.