Re: [Qemu-devel] [PATCH] tests: add QMP input visitor test for unions with no discriminator

[Eric Blake]

On 09/10/2014 07:02 PM, Michael Roth wrote:
> This more an exercise of the dealloc visitor, where it may erroneously

This is more of an exercise...

> use an uninitialized discriminator field as indication that union
> fields corresponding to that disciminator field/type are present,

discriminator

> which can lead to attempts to free random chunks of heap memory.
> 
> Signed-off-by: Michael Roth <address@hidden>
> ---
>  tests/qapi-schema/qapi-schema-test.json | 10 ++++++++++
>  tests/qapi-schema/qapi-schema-test.out  |  3 +++
>  tests/test-qmp-input-strict.c           | 17 +++++++++++++++++
>  3 files changed, 30 insertions(+)
> 

Reviewed-by: Eric Blake <address@hidden>

[conflicts with my stalled attempt to nuke inline sub-structs in json
files, where I've promised to send a v4 - guess I'll be rebasing as part
of reviving that series...]

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature