[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include fi
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file |
Date: |
Thu, 11 Sep 2014 17:40:54 +0200 |
Hi,
> > +enum virtgpu_ctrl_type {
> > + VIRTGPU_UNDEFINED = 0,
> >
>
> This is clearly all well out of line with our
> coding style guide, which isn't a terribly good start...
Oh yea, code style is fun. This file is needed in both qemu & linux
kernel, which have different code styles. I pipe it though a sed script
already when syncing them up, weeding out the tabs. I'll go tweak my
script to fix the indent too.
cheers,
Gerd
- [Qemu-devel] [PATCH 0/2] virtio-gpu: hardware specification, Gerd Hoffmann, 2014/09/11
- [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Gerd Hoffmann, 2014/09/11
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Peter Maydell, 2014/09/11
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Eric Blake, 2014/09/11
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Michael S. Tsirkin, 2014/09/14
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Peter Maydell, 2014/09/14
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Michael S. Tsirkin, 2014/09/14
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Peter Maydell, 2014/09/14
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Michael S. Tsirkin, 2014/09/14