qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, u


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()
Date: Thu, 11 Sep 2014 21:20:53 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Benoît Canet <address@hidden> writes:

> I have trouble to review this as I don't understand the qdevs parts.
> Maybe someone else could have a look at it.

The patch is big, but all it really does is replacing

    dinfo->bdrv

by

    blk_bs(blk_legacy_dinfo(dinfo))

Line wrapping muddies the waters a bit.  I also omit tests whether
dinfo->bdrv is null, because it never is.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]