Re: [Qemu-devel] checkpatch.pl false positive

[Peter Maydell]

On 12 September 2014 11:35, Gerd Hoffmann <address@hidden> wrote:
>   Hi,
>
> Hooked up checkpatch to my testbuild-patch-series script.
> Catched some issues, now trapped into what I think is a false positive:
>
> ERROR: Macros with complex values should be enclosed in parenthesis
> #995: FILE: include/hw/virtio/virtio-gpu.h:99:
> +#define DEFINE_VIRTIO_GPU_PCI_PROPERTIES(_state)               \
> +    DEFINE_PROP_BIT("ioeventfd", _state, flags,                \
> +                    VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, false), \
> +    DEFINE_PROP_UINT32("vectors", _state, nvectors, 4)
>
> enclosing into parenthesis just isn't going to fly here as this is an
> array snipped, not some piece of code we could wrap into the usual
> "{ $code } while (0)".

Yes, I think we should just expect that checkpatch is sometimes
going to get confused by complex macros. It's never going to
be 100% accurate.

-- PMM