[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/12] virtio-net: drop assert on vm stop
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 09/12] virtio-net: drop assert on vm stop |
Date: |
Sun, 14 Sep 2014 21:41:46 +0300 |
On vm stop, vm_running state set to stopped
before device is notified, so callbacks can get envoked with
vm_running = false; and this is not an error.
Cc: address@hidden
Acked-by: Jason Wang <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/net/virtio-net.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 826a2a5..2040eac 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1125,8 +1125,6 @@ static int32_t virtio_net_flush_tx(VirtIONetQueue *q)
return num_packets;
}
- assert(vdev->vm_running);
-
if (q->async_tx.elem.out_num) {
virtio_queue_set_notification(q->tx_vq, 0);
return num_packets;
--
MST
- [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes, Michael S. Tsirkin, 2014/09/14
- [Qemu-devel] [PULL 01/12] hw/machine: Free old values of string properties, Michael S. Tsirkin, 2014/09/14
- [Qemu-devel] [PULL 02/12] test-qdev-global-props: Trivial comment fix, Michael S. Tsirkin, 2014/09/14
- [Qemu-devel] [PULL 03/12] test-qdev-global-props: Run tests on subprocess, Michael S. Tsirkin, 2014/09/14
- [Qemu-devel] [PULL 04/12] test-qdev-global-props: Initialize not_used=true for all props, Michael S. Tsirkin, 2014/09/14
- [Qemu-devel] [PULL 05/12] test-qdev-global-props: Test handling of hotpluggable and non-device types, Michael S. Tsirkin, 2014/09/14
- [Qemu-devel] [PULL 06/12] qdev: Rename qdev_prop_check_global() to qdev_prop_check_globals(), Michael S. Tsirkin, 2014/09/14
- [Qemu-devel] [PULL 07/12] qdev: Move global validation to a single function, Michael S. Tsirkin, 2014/09/14
- [Qemu-devel] [PULL 08/12] Revert "rng-egd: remove redundant free", Michael S. Tsirkin, 2014/09/14
- [Qemu-devel] [PULL 09/12] virtio-net: drop assert on vm stop,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 10/12] Revert "virtio: don't call device on !vm_running", Michael S. Tsirkin, 2014/09/14
- [Qemu-devel] [PULL 11/12] virtio-pci: enable bus master for old guests, Michael S. Tsirkin, 2014/09/14
- [Qemu-devel] [PULL 12/12] vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation, Michael S. Tsirkin, 2014/09/14
- Re: [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes, Peter Maydell, 2014/09/15
- Re: [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes, Michael S. Tsirkin, 2014/09/16
- Re: [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes, Paolo Bonzini, 2014/09/16
- Re: [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes, Michael S. Tsirkin, 2014/09/16
- Re: [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes, Michael Roth, 2014/09/18