[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb-storage: Fix how legacy init handles option
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] usb-storage: Fix how legacy init handles option ID clash |
|
Date: |
Mon, 15 Sep 2014 08:40:49 +0200 |
On Fr, 2014-09-12 at 21:24 +0200, Markus Armbruster wrote:
> usb_msd_init() calls qemu_opts_create() with a made-up ID and false
> fail_if_exists. If the ID already exists, it happily messes up those
> options, then fails drive_new(), because the BlockDriverState with
> that ID already exists, too.
>
> Reproducer: -drive if=none,id=usb0,format=raw -usbdevice disk:tmp.qcow2
>
> Pass true fail_if_exists to qemu_opts_create(), and if it fails, try
> the next made-up ID.
>
> The reproducer now succeeds, and creates an usb-storage device with ID
> usb1.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Added to usb patch queue.
thanks,
Gerd