Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

[Gonglei (Arei)]

> > > >
> > > > Sorry, I don't understand your meaning. :(
> > >
> > > I applied your patch, and looked at the property types.
> > >
> > Could you tell me your method looked at properties type?
> 
> You can use an HMP command, or you can use
> -device virtio-net-pci,?

OK. Good method.

> changes must not modify output except for adding
> new commands, or fixing bugs (with care).
> 
OK. 

> > > They should be netdev/vlan/macaddr.
> > > Your patch makes them str/int32/str
> > >
> > Does those changes have any side-effects? Thanks!
> 
> Yes.  If the types are just "int" and "str" then you
> have no way to know they should have a specific format,
> such as a name of a netdev, valid mac address, or a vlan.
> In fact, vlan=int is a bug since vlan names aren't numbers.
> 
Got it. 

> > The similar changes for virtio-blk had applied in qemu master.
> >
> > Best regards,
> > -Gonglei
> 
> Which commit? Did output change? If yes it's a bug.

No, I checked it again, virtio-blk-pci's properties are 'int' type as
the same as virtio-blk device, so it will have no problem on this point. 

I will rework this patch series. Thanks a lot for review! :)

Best regards,
-Gonglei